Skip to content

gh-66113: Add unit tests for Turtle guionly #129532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jan 31, 2025

Ill finish this off as #13494 has had 2 years of inactivity and no progress.

Co-authored-by: Sanyam Khurana <Sanyam@sanyamkhurana.com>
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jan 31, 2025
@StanFromIreland
Copy link
Member Author

ping @matrixise @taleinat

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Feb 1, 2025

It seems GitHub actions does not have the capabilities for running this test and must be run by a user. Any advice @terryjreedy (If I remember correctly you contributed quite a lot to turtle)

This would have to be a user only test.

@terryjreedy
Copy link
Member

The first failure is trying to open couldn't open a non-existent file. "D:\a\cpython\cpython\Lib\test/imghdrdata/python.gif": no such file or directory" Not on my system either for installed or repository versions. The others are for turtle.getscreen()._xxxx()calls raisingturtle.Terminator`. The latter also happens on my Windows system. Did the tests run for you? If so, which OS and which exact binary. What is the initial line when you run interactively?

To run just the test file, it needs the following added at the end.



if __name__ == '__main__':
    unittest.main()

I don't know anything in particular about testing turtle. I have only worked with turtledemo. Ping whoever has worked on test_turtle if not already.

@terryjreedy
Copy link
Member

The first failure is trying to open couldn't open a non-existent file. "D:\a\cpython\cpython\Lib\test/imghdrdata/python.gif": no such file or directory" Not on my system either for installed or repository versions. The others are for turtle.getscreen()._xxxx()calls raisingturtle.Terminator`. The latter also happens on my Windows system. To see errors, click snowflake on middle upper right edge of Details and then "View raw logs" and scroll to near bottom.

Did the tests run for you? If so, which OS and which exact binary. What is the initial line when you run interactively?

To run just the test file, it needs the following added at the end.



if __name__ == '__main__':
    unittest.main()

I don't know anything in particular about testing turtle. I have only worked with turtledemo. Ping whoever has worked on test_turtle if not already.

@StanFromIreland StanFromIreland marked this pull request as draft February 2, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants