Skip to content

gh-89867: string.Formatter auto numbering doc updates #129617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025

Conversation

dg-pb
Copy link
Contributor

@dg-pb dg-pb commented Feb 3, 2025

@dg-pb
Copy link
Contributor Author

dg-pb commented Apr 29, 2025

@ZeroIntensity any chance you could check this one?

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not enough of an expert here to review, but the English and markup look mostly fine to me (see my one comment). I think @picnixz is the right person to tag, but he's going to be out for a little while last I heard.

@dg-pb
Copy link
Contributor Author

dg-pb commented Apr 29, 2025

Thanks, english check is what I hoped for.

Regarding logic, maybe @encukou could have a look? This is just clarifying docs after #21767.

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@encukou encukou merged commit a4b7128 into python:main Apr 30, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Apr 30, 2025
mth4saurabh pushed a commit to mth4saurabh/cpython that referenced this pull request Apr 30, 2025
@dg-pb dg-pb deleted the string_formatter_parse_doc_update branch April 30, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants