Skip to content

gh-128911: Use PyImport_ImportModuleAttr() function #129657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2025
Merged

gh-128911: Use PyImport_ImportModuleAttr() function #129657

merged 3 commits into from
Feb 5, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 4, 2025 •
edited by bedevere-app bot
Loading

  • Replace PyImport_ImportModule() + PyObject_GetAttr() with PyImport_ImportModuleAttr().
  • Replace PyImport_ImportModule() + PyObject_GetAttrString() with PyImport_ImportModuleAttrString().

@vstinner
pythongh-128911: Use PyImport_ImportModuleAttr() function
76ba47e 
* Replace PyImport_ImportModule() + PyObject_GetAttr() with
  PyImport_ImportModuleAttr().
* Replace PyImport_ImportModule() + PyObject_GetAttrString() with
  PyImport_ImportModuleAttrString().
@vstinner vstinner requested review from ericsnowcurrently and a team as code owners February 4, 2025 15:20
@bedevere-app bedevere-app bot mentioned this pull request Feb 4, 2025
Closed
@vstinner vstinner merged commit dc804ff into python:main Feb 5, 2025
41 checks passed
@vstinner vstinner deleted the use_importattr branch February 5, 2025 10:04
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@vstinner @srinivasreddy
pythongh-128911: Use PyImport_ImportModuleAttr() function (python#129657
92260e3 
)

* Replace PyImport_ImportModule() + PyObject_GetAttr() with
  PyImport_ImportModuleAttr().
* Replace PyImport_ImportModule() + PyObject_GetAttrString() with
  PyImport_ImportModuleAttrString().
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
@vstinner @cmaloney
pythongh-128911: Use PyImport_ImportModuleAttr() function (python#129657
8ed58cd 
)

* Replace PyImport_ImportModule() + PyObject_GetAttr() with
  PyImport_ImportModuleAttr().
* Replace PyImport_ImportModule() + PyObject_GetAttrString() with
  PyImport_ImportModuleAttrString().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vstinner