Skip to content

gh-111178: fix UBSan failures in Modules/_hashopenssl.c #129802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 26, 2025
Merged

gh-111178: fix UBSan failures in Modules/_hashopenssl.c #129802

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fd378ad
fix UBSan failures for `EVPobject`
picnixz Jan 25, 2025
77493a4
fix UBSan failures for `HMACobject`
picnixz Jan 25, 2025
7c59c74
suppress unused return values
picnixz Jan 25, 2025
66cf1fb
remove redundant casts
picnixz Jan 25, 2025
3008ebb
Merge remote-tracking branch 'upstream/main' into fix/ubsan/hashlib-1…
picnixz Jan 25, 2025
b676e6c
Merge remote-tracking branch 'upstream/main' into fix/ubsan/hashlib-1…
picnixz Feb 7, 2025
b932b83
Do Do not use `_` + capital letter in new code as it is also UB.
picnixz Feb 8, 2025
1d62ecd
Merge branch 'main' into fix/ubsan/hashlib-111178
picnixz Feb 16, 2025
26faaa5
fix a bad representation!
picnixz Feb 25, 2025
30e0c9b
remove unnecessary forward declaration
picnixz Feb 25, 2025
c4cd5bb
Merge in the main branch
encukou Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix a bad representation!
  • Loading branch information
@picnixz
picnixz committed Feb 25, 2025
commit 26faaa59b44e07ab6e5eb227e505ddf08aacf5f7
5 changes: 3 additions & 2 deletions Modules/_hashopenssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1706,9 +1706,10 @@ _hmac_dealloc(PyObject *op)
}

static PyObject *
_hmac_repr(PyObject *self)
_hmac_repr(PyObject *op)
{
PyObject *digest_name = _hashlib_hmac_get_name(self, NULL);
HMACobject *self = HMACobject_CAST(op);
PyObject *digest_name = py_digest_name(HMAC_CTX_get_md(self->ctx));
if (digest_name == NULL) {
return NULL;
}
Expand Down