gh-129928: Raise more accurate exception for sqlite3 UDF creation misuse #129941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on misuse Consistently raise ProgrammingError if the user tries to create an UDF with an invalid number of parameters.
fa21de0 to
8424b44
Compare
erlend-aasland
commented
Feb 10, 2025
| check_num_params(pysqlite_Connection *self, const int n, const char *name) | ||
| { | ||
| int limit = sqlite3_limit(self->db, SQLITE_LIMIT_FUNCTION_ARG, -1); | ||
| assert(limit >= 0); |
There was a problem hiding this comment.
As long as we call this on a valid database pointer (checked via pysqlite_check_connection), we can assert we won't fail here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistently raise ProgrammingError if the user tries to create an UDF
with an invalid number of parameters.