Skip to content

reinit the TLS before anything else #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2017
Merged

reinit the TLS before anything else #130

merged 1 commit into from
Feb 21, 2017

Conversation

benjaminp
Copy link
Contributor

PyEval_ReInitThread can run arbitrary Python code, which really ought to have
the TLS properly initialized. This essentially backports the Python 3 ordering.

PyEval_ReInitThread can run arbitrary Python code, which really ought to have
the TLS initialized.
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really qualified to review this, but... since you're the RM of 2.7 and this is a backport from Python 3 here's my +1 :)

@benjaminp benjaminp merged commit d9a7574 into 2.7 Feb 21, 2017
@berkerpeksag berkerpeksag deleted the benjamin-reinit-tls branch February 21, 2017 07:53
akruis referenced this pull request in stackless-dev/stackless Sep 5, 2017
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Pickling of an exhausted generator no longer causes a segmentation fault.

https://bitbucket.org/stackless-dev/stackless/issues/130
(grafted from b86bda31f4e3372bbde61179cc890af24d83ae71)
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
akruis pushed a commit to akruis/cpython that referenced this pull request Nov 7, 2017
akruis pushed a commit to akruis/cpython that referenced this pull request Mar 25, 2018
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants