Skip to content

gh-130077: Enhance GrammarVisitor to differentiate visit methods for single and multi-character node classes #130162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

gh-130077: Enhance GrammarVisitor to differentiate visit methods for single and multi-character node classes #130162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a5cf286
Enhance GrammarVisitor to differentiate visit methods for single and …
isatyamks Feb 15, 2025
c201c17
Merge branch 'main' into #130077
isatyamks Feb 15, 2025
b4ce07d
Merge branch 'main' into #130077
isatyamks Feb 16, 2025
b67b1aa
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 16, 2025
af90e6d
Update Tools/peg_generator/pegen/grammar.py
isatyamks Feb 16, 2025
a359908
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 16, 2025
9bf0911
Merge branch 'main' into #130077
isatyamks Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Build/2025-02-16-06-20-22.gh-issue-130077.DkWL_j.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix potential memory leak in c-field representation of Python objects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem related to the actual change. Is this from a different PR?


Resolved a memory leak issue in the `_PyObject_CAST` macro by ensuring proper casting and handling of c-fields. This fix improves memory management and prevents unintended behavior in CPython's internal object representation.
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Build/2025-02-16-06-45-42.gh-issue-130077.DkWL_j.rst
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's two blurb files, go ahead and delete one of them.

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix potential memory leak in c-field representation of Python objects

Resolved a memory leak issue in the `_PyObject_CAST` macro by ensuring proper casting and handling of c-fields. This fix improves memory management and prevents unintended behavior in CPython's internal object representation.
7 changes: 6 additions & 1 deletion Tools/peg_generator/pegen/grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ class GrammarError(Exception):
class GrammarVisitor:
def visit(self, node: Any, *args: Any, **kwargs: Any) -> Any:
"""Visit a node."""
method = "visit_" + node.__class__.__name__
node_cls = node.__class__.__name__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use type(), not __class__.

method = f"visit_{node_cls}"
if len(node.__class__.__name__) == 1:
method = f"visit_single_{node_cls}"
elif len(node.__class__.__name__) > 1:
method = f"visit_multi_{node_cls}"
visitor = getattr(self, method, self.generic_visit)
return visitor(node, *args, **kwargs)

Expand Down
Loading