Skip to content

gh-130167: Improve speed of inspect.formatannotation by replacing re #130242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+5 −5
Open

gh-130167: Improve speed of inspect.formatannotation by replacing re #130242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef19ae6
Improve speed of inspect.formatannotation by replacing re
donBarbos Feb 17, 2025
7dc08b7
Merge branch 'main' into improve-inspect-speed
donBarbos Feb 18, 2025
d9480c7
Add blurb
donBarbos Feb 18, 2025
ab85241
Update NEWS.d entry markup
donBarbos Feb 18, 2025
f48b2ed
Merge branch 'main' into improve-inspect-speed
donBarbos Mar 27, 2025
3c1c4b7
Update rst syntax in News entry
donBarbos Mar 27, 2025
1bfbe05
Update 2025-02-18-05-04-13.gh-issue-130167.aOgAz_.rst
donBarbos Mar 27, 2025
0ecf16f
Remove implementation detail from News entry
donBarbos Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Lib/inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@
import itertools
import linecache
import os
import re
import sys
import tokenize
import token
Expand Down Expand Up @@ -1334,10 +1333,10 @@ def formatannotation(annotation, base_module=None, *, quote_annotation_strings=T
if not quote_annotation_strings and isinstance(annotation, str):
return annotation
if getattr(annotation, '__module__', None) == 'typing':
def repl(match):
text = match.group()
return text.removeprefix('typing.')
return re.sub(r'[\w\.]+', repl, repr(annotation))
return (repr(annotation)
.replace(".typing.", "@TYPING@")
.replace("typing.", "")
.replace("@TYPING@", ".typing."))
if isinstance(annotation, types.GenericAlias):
return str(annotation)
if isinstance(annotation, type):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-02-18-05-04-13.gh-issue-130167.aOgAz_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve speed of :func:`!inspect.formatannotation`. Patch by Semyon Moroz.
Loading