gh-130384: Skip a test_getallocatedblocks test pre-condition on iOS. #130385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 9b311b3 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130385%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
The pre-condition is wrong #130384 (comment), so I think it would be fine to remove the precondition altogether. |
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#130007 introduced a change to the handling of C stack limits, which caused the
test_sys.SysModuleTest.get_allocated_blocks()test to start failing in CI on iOS.This PR skips the specific test precondition that is causing the test failure when running on iOS. This is based on the fact that the assertion appears to be a precondition that has some other "escape clauses" (like running on a free threading build), and is documented as asserting something that is "unlikely to happen in a normal test run". I don't know why iOS is causing the "unlikely" condition to happen reliably in CI... but it apparently does.
I'll be honest - I don't feel good about this PR. However, I don't have anywhere near enough knowledge or experience to understand what interaction of memory allocation and garbage collection would be causing this to only occur on iOS, and only in CI. I can't reproduce the problem locally, and it doesn't appear to be causing any larger issues with operation on iOS.
test_sys.SysModuleTest.get_allocated_blockstest precondition intermittently fails on iOS #130384