Skip to content

gh-128627: Skip wasm-gc on iOS Safari where it's broken #130418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2025
Merged

gh-128627: Skip wasm-gc on iOS Safari where it's broken #130418

merged 3 commits into from
Feb 23, 2025

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Feb 21, 2025 •
edited by bedevere-app bot
Loading

As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Downstream pyodide issue: pyodide/pyodide#5428.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

@ambv
pythongh-128627: Skip wasm-gc on iOS Safari where it's broken
0da9a0c 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load.
Downstream pyodide issue: pyodide/pyodide#5428.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.
@bedevere-app bedevere-app bot mentioned this pull request Feb 21, 2025
Closed
@ambv ambv added the skip news label Feb 21, 2025
ambv added a commit to ambv/pyodide that referenced this pull request Feb 21, 2025
@ambv
Skip wasm-gc on iOS Safari where it's borked
6324ebd 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load.
Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
@ambv ambv mentioned this pull request Feb 21, 2025
Merged
ambv added a commit to ambv/pyodide that referenced this pull request Feb 21, 2025
@ambv
Skip wasm-gc on iOS Safari where it's borked
3432a3b 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load.
Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
@hoodmane
Copy link
Contributor

Thanks @ambv!

hoodmane
hoodmane reviewed Feb 21, 2025
View reviewed changes
freakboy3742
freakboy3742 reviewed Feb 22, 2025
View reviewed changes
@ambv @hoodmane
Don't use navigator if it doesn't exist (hi, Node)
2d706e6 
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
freakboy3742
freakboy3742 approved these changes Feb 23, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the fix!

@freakboy3742 freakboy3742 merged commit 72ea3c0 into python:main Feb 23, 2025
45 checks passed
hoodmane pushed a commit to pyodide/pyodide that referenced this pull request Feb 24, 2025
@ambv
Skip wasm-gc on iOS Safari where it's borked (#5445)
fb4d18d 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves #5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 24, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
aeb2b80 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
5dc2f76 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
ecdb784 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
0b8c748 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
4e0e330 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
1821662 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
1330862 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
5a4da64 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
c63b455 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
4010396 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
ac22880 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 25, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
1036f6f 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Feb 26, 2025
@ambv @hoodmane
Skip wasm-gc on iOS Safari where it's borked (pyodide#5445)
b6865f9 
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.

macOS Safari 18.3 does not surface the issue.

Confirmed on device that disabling this restores interpreter function.

Resolves pyodide#5428.
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@ambv @hoodmane @seehwan80
pythongh-128627: Skip wasm-gc on iOS Safari where it's broken (python…
2925428 
…#130418)

As of iOS 18.3.1, enabling wasm-gc breaks the interpreter. This disables the wasm-gc
trampoline on iOS.

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@ambv ambv deleted the skip-wasm-gc-ios branch May 5, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoodmane hoodmane hoodmane approved these changes

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ambv @hoodmane @freakboy3742