[3.13] GH-121970: Extract pydoc_topics into a new extension (#129116)
#130441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pythonGH-129116) (cherry picked from commit 01bcf13) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
pydoc_topics into a new extension (#129116)pydoc_topics into a new extension (#129116)
# Conflicts: # Doc/tools/extensions/pyspecific.py
|
Will this also introduce the lint failure during the next release? |
I still haven't managed to reproduce the error (note this PR is fine). Local tests with the offending doctest line also seem fine. |
|
I can reproduce on cd Doc
make clean venv pydoc-topics
cp build/pydoc-topics/topics.py ../Lib/pydoc_data/topics.pyIt adds a trailing space on line 5617. The release process does this, but the regular CI doesn't, so PRs will pass. |
|
This is very odd. I thought it might be my IDE stripping line endings, so I ran the following from a powershell terminal with my IDE closed: A few changes, but nothing on 5617... I will attempt to try via WSL... Edit: Same result via WSL... $ cd Doc
$ make clean venv pydoc-topics
$ cp build/pydoc-topics/topics.py ../Lib/pydoc_data/topics.py
$ git commit -am tmp |
|
#130492 has now been merged, I'll apply the backport labels to it when these PRs are merged. |
hugovk
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 01bcf13)
pyspecific#121970📚 Documentation preview 📚: https://cpython-previews--130441.org.readthedocs.build/