Add test checking value of a TypedDict's __total__ attribute when there is an assignment in the class body. #130460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In relation to python#109544 which changed this behavior. Signed-off-by: Daniel Sperber <github.blurry@9ox.net>
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
picnixz
reviewed
Feb 22, 2025
JelleZijlstra
approved these changes
Feb 22, 2025
picnixz
approved these changes
Feb 22, 2025
Daraan
added a commit
to Daraan/typing_extensions
that referenced
this pull request
Feb 22, 2025
Daraan
added a commit
to Daraan/typing_extensions
that referenced
this pull request
Feb 22, 2025
Daraan
added a commit
to Daraan/typing_extensions
that referenced
this pull request
Feb 22, 2025
|
Thanks @Daraan for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 22, 2025
…re is an assignment in the class body. (pythonGH-130460) In relation to pythonGH-109544 which changed this behavior. (cherry picked from commit d8ce092) Co-authored-by: Daraan <github.blurry@9ox.net> Signed-off-by: Daniel Sperber <github.blurry@9ox.net>
|
GH-130462 is a backport of this pull request to the 3.13 branch. |
JelleZijlstra
pushed a commit
that referenced
this pull request
Feb 22, 2025
…hen there is an assignment in the class body. (GH-130460) (#130462) Add test checking value of a TypedDict's __total__ attribute when there is an assignment in the class body. (GH-130460) In relation to GH-109544 which changed this behavior. (cherry picked from commit d8ce092) Signed-off-by: Daniel Sperber <github.blurry@9ox.net> Co-authored-by: Daraan <github.blurry@9ox.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#109544 introduced a change in an out of spec usage when a value is assigned to
__total__in the class body.In such a case the assigned value is currently overwritten. Added a test cast for verification (asked by @JelleZijlstra).
Related comments from
typing_extensionspython/typing_extensions#519 (comment)
python/typing_extensions#519 (comment)