Skip to content

gh-130482: Add ability to specify name for tkinter.OptionMenu and tkinter.ttk.OptionMenu #130502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 2, 2025
Merged

gh-130482: Add ability to specify name for tkinter.OptionMenu and tkinter.ttk.OptionMenu #130502

merged 6 commits into from
May 2, 2025
+19 −2

Conversation

Xiaokang2022
Copy link
Contributor

@Xiaokang2022 Xiaokang2022 commented Feb 24, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 24, 2025
Closed
@Xiaokang2022
Copy link
Contributor Author

@serhiy-storchaka Sorry to bother you, can you please help review this PR? Thank you so much!

@serhiy-storchaka serhiy-storchaka self-requested a review May 1, 2025 14:24
serhiy-storchaka
serhiy-storchaka approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

I left few suggestions for tests. You can accept them or reject.

Xiaokang2022 and others added 2 commits May 2, 2025 13:57
@Xiaokang2022 @serhiy-storchaka
Update Lib/test/test_tkinter/test_widgets.py
6b24526 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@Xiaokang2022 @serhiy-storchaka
Update Lib/test/test_ttk/test_extensions.py
e2091ed 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@Xiaokang2022
Copy link
Contributor Author

LGTM. 👍

I left few suggestions for tests. You can accept them or reject.

Thank you for helping to review this PR. I have accepted all of your suggestions.

@serhiy-storchaka serhiy-storchaka merged commit e490c00 into python:main May 2, 2025
39 checks passed
@serhiy-storchaka
Copy link
Member

Thank you for your contribution @Xiaokang2022.

@Xiaokang2022 Xiaokang2022 deleted the improve-OptionMenu branch May 2, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@kurawlefaraaz kurawlefaraaz kurawlefaraaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xiaokang2022 @serhiy-storchaka @kurawlefaraaz