gh-130647: Add --omit-header option to pygettext
#130650
Conversation
|
Also @serhiy-storchaka |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Anything else left to do here @tomasr8 ? |
|
Little reminder @serhiy-storchaka |
Might I ask why? The implementation does effect anything beyond the header, it is literally a single |
|
Why to add this feature at first place? If it is for tests, we should ensure that it works with non-ASCII strings. Otherwise this option will be useless. We need also tests with non-ASCII strings for |
See the linked issue, this was discussed before.
This feature just removes the POT header. |
|
Friendly ping @serhiy-storchaka :-) |
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
There was a problem hiding this comment.
The problem with this feature is that we are losing information about the .po file encoding, which is locale depending. Therefore, files generated on different computers may be incompatible. There is an issue with using the default file encoding in general, because it may be not compatible with the source file encoding (msgids and comments) and filesystem encoding (file names).
We can probably just ignore this for now. And then somehow solve all the encoding problems at once.
But adding a feature that contains an inherent flaw leaves a bitter aftertaste.
Requesting @tomasr8 :-)
--omit-headeroption #130647