Skip to content

gh-130703: Implement wrapping to width for msgids #130705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

gh-130703: Implement wrapping to width for msgids #130705

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
b3ccc45
Add logic to wrap and test
StanFromIreland Feb 28, 2025
33149ed
Fix NEWS name -- We don't want miliseconds
StanFromIreland Feb 28, 2025
0e35e36
Change extract func in test
StanFromIreland Feb 28, 2025
92f227f
Use a modified version of pybabel's code in normalize
StanFromIreland Mar 1, 2025
f0ee9c4
Minor tweak
StanFromIreland Mar 1, 2025
843e3fa
Update argparse snapshot
StanFromIreland Mar 1, 2025
7fc34ca
Bénédikt's suggestions
picnixz Mar 1, 2025
8d319b4
Preserve spaces and remove unnecessary checks
StanFromIreland Mar 1, 2025
9197688
Improve comment
StanFromIreland Mar 1, 2025
7c8637e
Add test and sort imports
StanFromIreland Mar 1, 2025
66d8eac
Benedikt's suggestion
StanFromIreland Mar 1, 2025
430c051
Add tests and simplify normalize
StanFromIreland Mar 2, 2025
abb90c2
tomasr8 suggestion
StanFromIreland Mar 2, 2025
7f947db
Fix typo in test str
StanFromIreland Mar 2, 2025
ea5fa91
Benedikt's suggestions
StanFromIreland Mar 2, 2025
4b02678
More of Benedikt's suggestions
StanFromIreland Mar 2, 2025
8d03cbf
Don't wrap for single words
StanFromIreland Mar 2, 2025
fbe5b93
Address Serhiy's suggestions
StanFromIreland Mar 2, 2025
8d5f84f
Use more complex pattern
StanFromIreland Mar 2, 2025
ae53774
Serhiy's suggestions
StanFromIreland Mar 2, 2025
794fc8b
Serhiy's suggestions
StanFromIreland Mar 3, 2025
47bfa29
Clean up
StanFromIreland Mar 3, 2025
b6f128f
Apply suggestions from Tomas
StanFromIreland Mar 3, 2025
a4823a7
Apply suggestions from Serhiy
StanFromIreland Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change extract func in test
  • Loading branch information
@StanFromIreland
StanFromIreland committed Feb 28, 2025
commit 0e35e36eb3ce4151522ec24c5c8f9317e0e7b79a
2 changes: 1 addition & 1 deletion Lib/test/test_tools/test_i18n.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def test_POT_Creation_Date(self):
datetime.strptime(creationDate, '%Y-%m-%d %H:%M%z')

def test_wrap_to_width(self):
msgid = self.extract_docstrings_from_str(
msgid = self.extract_from_str(
'''_("thisisaveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryverlongstring")''')
self.assertIn('\nlongstring', msgid[1])

Expand Down
Loading