-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-110067: Make max heap methods public and add missing ones #130725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
eccf484
Initial addition
StanFromIreland beaf915
Add C imp
StanFromIreland c143ae2
Benedikts suggestions
StanFromIreland 167525d
Benedikts suggestions
StanFromIreland 1b0b6f3
Update Modules/_heapqmodule.c with Benedikts suggestion
StanFromIreland fc46707
Fix mistake (extra underscores)
StanFromIreland f4fd94a
Benedikt's requested changes
StanFromIreland cebbc88
Missed one of Benedikt's requested changes
StanFromIreland 3cde6c6
Benedikts suggestion
StanFromIreland 5d2d387
Benedikts Suggestions
StanFromIreland a499cd4
Fix doc warnings
StanFromIreland abe0a95
Improve entries
StanFromIreland 3561206
Address some of Petr's suggestions
StanFromIreland 8fd1a03
Clean up and add missing
StanFromIreland 8ab97c2
Update Doc/library/heapq.rst
StanFromIreland 623cae7
Merge branch 'main' into add-heapq-max
StanFromIreland 81db251
Sort and add missing C implementation
StanFromIreland 38cbf13
Petr's list suggestion
StanFromIreland b6f4db4
heappushpop_max fixup
StanFromIreland 61c9285
Improve test
StanFromIreland ebe00dc
Switch to <
StanFromIreland bc0dd66
Clean up test
StanFromIreland 988b2d3
Reword the docs
encukou 6efd70c
Add max-heap variants for the other tests
encukou 4ba533b
Apply suggestions from code review
encukou 160bc35
Merge pull request #1 from encukou/add-heapq-max
StanFromIreland 742c46c
final touchups
StanFromIreland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.