Skip to content

[3.12] gh-130740: Move some stdbool.h includes after Python.h (#130738) #130757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
include stdbool.h in opcode_metadata.h
  • Loading branch information
picnixz committed Mar 2, 2025
commit efd75da3fa72b827b08fa2cc56a6fc535cde0e87
2 changes: 2 additions & 0 deletions Python/opcode_metadata.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// Python/bytecodes.c
// Do not edit!

#include <stdbool.h>

#ifndef NEED_OPCODE_METADATA
extern int _PyOpcode_num_popped(int opcode, int oparg, bool jump);
#else
Expand Down
3 changes: 3 additions & 0 deletions Tools/cases_generator/generate_cases.py
Original file line number Diff line number Diff line change
Expand Up @@ -986,6 +986,9 @@ def write_metadata(self) -> None:
self.out.write_raw(self.from_source_files())
self.out.write_raw(f"// Do not edit!\n")

self.out.write_raw("\n")
self.out.write_raw("#include <stdbool.h>")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you add <stdbool.h> include?

Copy link
Member Author

@picnixz picnixz Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there are some bool inside the generate_metadata.h file which, without this include, doesn't compile. Previously, it was because we included stdbool.h before including this file so it was impliticitly available (see https://github.com/python/cpython/actions/runs/13614386994/job/38055588576?pr=130757)

self.out.write_raw("\n")

self.write_stack_effect_functions()

Expand Down
Loading