gh-130827: Support typing.Self annotations in singledispatchmethod()
#130829
Conversation
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
| # But, it shouldn't work on singledispatch() | ||
| with self.assertRaises(TypeError): | ||
| @test.register | ||
| def silly(self: typing.Self, arg: int | str) -> int | str: |
There was a problem hiding this comment.
Will 'typing.Self' annotation work the same way?
There was a problem hiding this comment.
Good question! It should, yeah. get_type_hints handles forward references.
There was a problem hiding this comment.
Should we add a test case for that, maybe?
There was a problem hiding this comment.
Possibly, but as long as get_type_hints is working it's probably fine.
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
|
@vstinner I'd like to get this fixed before 3.12 goes security-only next week. Would you mind reviewing? |
|
Wait why would we want to change this in 3.12 at all? Seems like a new feature to me. |
|
I agree, this is a new feature and should not be backported. |
|
Agreed with Jelle, this is a feature best left for a new release. Otherwise it's too hard to guard against in user code. |
|
Makes sense. I've updated the issue. |
|
Bump. I'd like to land this one before the beta freeze. |
singledispatchmethod.registerfails withtyping.Selfannotation #130827