gh-130821: Add type information to wrong type error messages #130835
+77
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstasiak
reviewed
Mar 8, 2025
it seems that we don't check the text of error messages if we don't want to check the error type itself |
skirpichev
reviewed
Apr 28, 2025
| @@ -1421,17 +1423,17 @@ _PyNumber_Index(PyObject *item) | |||
|
|
|||
| if (!PyLong_Check(result)) { | |||
| PyErr_Format(PyExc_TypeError, | |||
| "__index__ returned non-int (type %.200s)", | |||
There was a problem hiding this comment.
I don't see much reason to change this error message either.
There was a problem hiding this comment.
I changed it to the more common way as you recommended elsewhere: __method__() must return an int, not ...
and added type info before method name, like for other methods
| @@ -2435,10 +2436,8 @@ method_output_as_list(PyObject *o, PyObject *meth) | |||
| PyThreadState *tstate = _PyThreadState_GET(); | |||
| if (_PyErr_ExceptionMatches(tstate, PyExc_TypeError)) { | |||
| _PyErr_Format(tstate, PyExc_TypeError, | |||
| "%.200s.%U() returned a non-iterable (type %.200s)", | |||
There was a problem hiding this comment.
Here I strongly prefer the old message. Iterable is not a type, it's a category of types.
There was a problem hiding this comment.
what do you think about new message: "%T.%U() must return an iterable, not %T"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got next output for use case from issue:
but we still have a lot of other places where wrong type errors have inconsistent messages. should they be updated too?