Skip to content

Mention the "context manager" keyword in concurrent.futures documentation #130976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025

Conversation

jstasiak
Copy link
Contributor

@jstasiak jstasiak commented Mar 8, 2025

I was searching for context manager-related part part of this documentation and I couldn't find anything because the words "context manager" weren't actually used anywhere.

I think this will help with discoverability of this feature.


📚 Documentation preview 📚: https://cpython-previews--130976.org.readthedocs.build/

…tion

I was searching for context manager-related part part of this documentation
and I couldn't find anything because the words "context manager"
weren't actually used anywhere.

I think this will help with discoverability of this feature.
@jstasiak
Copy link
Contributor Author

jstasiak commented Mar 8, 2025

There are more lines changed than strictly necessary because I maintained the overall line length in that section, let me know if I should do otherwise.

@ZeroIntensity ZeroIntensity added skip issue needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 9, 2025
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 10, 2025
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@kumaraditya303 kumaraditya303 merged commit 095bc77 into python:main Aug 15, 2025
42 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Aug 15, 2025
@miss-islington-app
Copy link

Thanks @jstasiak for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2025
…tion (pythonGH-130976)

(cherry picked from commit 095bc77)

Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2025
…tion (pythonGH-130976)

(cherry picked from commit 095bc77)

Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
@bedevere-app
Copy link

bedevere-app bot commented Aug 15, 2025

GH-137810 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 15, 2025
@bedevere-app
Copy link

bedevere-app bot commented Aug 15, 2025

GH-137811 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 15, 2025
kumaraditya303 pushed a commit that referenced this pull request Aug 15, 2025
…cumentation (GH-130976) (#137811)

Mention the "context manager" keyword in concurrent.futures documentation (GH-130976)
(cherry picked from commit 095bc77)

Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants