gh-89157: Make C and Python implementation of datetime.date.fromisoformat consistent.
#131007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
StanFromIreland
commented
Mar 9, 2025
•
- Issue: datetime's C implementation verifies fromisoformat is ASCII, but the pure python implementation does not #89157
|
Implementation is fine I just need to clear up tests as C raises a Value error but Python a TypeError will get this done soon enough |
pganssle
approved these changes
Mar 26, 2025
|
Thanks for merging @hugovk :-) |
|
Thanks for the PR! |
pganssle
reviewed
Apr 24, 2025
pganssle
reviewed
Apr 24, 2025
| @@ -3534,7 +3535,7 @@ def test_fromisoformat_fails_datetime(self): | |||
| '2009-04-19T03:15:4500:00', # Bad time zone separator | |||
| '2009-04-19T03:15:45.123456+24:30', # Invalid time zone offset | |||
| '2009-04-19T03:15:45.123456-24:30', # Invalid negative offset | |||
| '2009-04-10ᛇᛇᛇᛇᛇ12:15', # Too many unicode separators | |||
There was a problem hiding this comment.
Why was this changed? The problem isn't that there are Unicode characters but that there is more than one of them. The old description was now accurate.
There was a problem hiding this comment.
It is a bit late now, it probably should have been asked a month ago when you approved this. In hindsight I agree the previous one was better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.