gh-130664: specify how thousands separators are used with 0-padding #131030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Mar 10, 2025
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
effigies
approved these changes
Apr 6, 2025
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
picnixz
reviewed
Aug 2, 2025
Doc/library/string.rst
Outdated
| @@ -426,7 +426,9 @@ If not specified, then the field width will be determined by the content. | |||
| When no explicit alignment is given, preceding the *width* field by a zero | |||
| (``'0'``) character enables sign-aware zero-padding for numeric types, | |||
| excluding :class:`complex`. This is equivalent to a *fill* character of | |||
| ``'0'`` with an *alignment* type of ``'='``. | |||
| ``'0'`` with an *alignment* type of ``'='``. If digit group separators of the | |||
There was a problem hiding this comment.
I'm a bit surprised that "digit group separator" is mentioned here while we only mention it in the "grouping option" paragraph below. Maybe we should mention it at that place or mention here that this will be introduced below?
There was a problem hiding this comment.
Since the different parts of the format are interconnected, there may be references to options described in details below.
But I think that we should unify wording and avoid repetition of what specifies the grouping option. "If the grouping option for the integral part is used, a digit group separator is also inserted between leading zeros."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--131030.org.readthedocs.build/