Skip to content

gh-117174: Adapt test_multiple_statements_fail_early now that we have always source #131065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 10, 2025

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Mar 10, 2025
@pablogsal pablogsal self-assigned this Mar 10, 2025
@pablogsal pablogsal added needs backport to 3.13 bugs and security fixes skip news labels Mar 10, 2025
@pablogsal pablogsal enabled auto-merge (squash) March 10, 2025 22:52
@pablogsal pablogsal merged commit 4192ce1 into python:main Mar 10, 2025
46 checks passed
@pablogsal pablogsal deleted the 117174-2 branch March 10, 2025 23:10
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4192ce17ba643e5b0bc9d2182a429002e4cc9dfe 3.13

@pablogsal
Copy link
Member Author

Thios doesn't need to be backported to 3.13 because the test doesn't exist there

@encukou encukou removed the needs backport to 3.13 bugs and security fixes label Mar 11, 2025
@bswck
Copy link
Contributor

bswck commented Mar 28, 2025

Related to #130513 (the cause of failures).

@bswck
Copy link
Contributor

bswck commented Mar 28, 2025

@hugovk if we fix the failure as in this PR, the buildbot should pass.

Yhg1s pushed a commit that referenced this pull request Mar 28, 2025
…havior (follow-up gh-131065) (#131836)

Adapt test to new REPL behavior (follow-up gh-117174)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 28, 2025
…EPL behavior (follow-up pythongh-131065) (pythonGH-131836)

Adapt test to new REPL behavior (follow-up pythongh-117174)
(cherry picked from commit a6cf827)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@Yhg1s Yhg1s added the needs backport to 3.13 bugs and security fixes label Mar 28, 2025
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 28, 2025
…e have always source (pythonGH-131065)

(cherry picked from commit 4192ce1)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 28, 2025

GH-131850 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 28, 2025
@Yhg1s
Copy link
Member

Yhg1s commented Mar 28, 2025

(Test now does exist in 3.13 so the fix needs backporting.)

Yhg1s pushed a commit that referenced this pull request Mar 28, 2025
…we have always source (GH-131065) (#131850)

gh-117174: Adapt test_multiple_statements_fail_early now that we have always source (GH-131065)
(cherry picked from commit 4192ce1)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Yhg1s pushed a commit that referenced this pull request Mar 28, 2025
…REPL behavior (follow-up gh-131065) (GH-131836) (#131841)

gh-117174: Adapt `test_multiple_statements_fail_early` to new REPL behavior (follow-up gh-131065) (GH-131836)

Adapt test to new REPL behavior (follow-up gh-117174)
(cherry picked from commit a6cf827)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
…EPL behavior (follow-up pythongh-131065) (python#131836)

Adapt test to new REPL behavior (follow-up pythongh-117174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants