Skip to content

gh-93096: Remove -t and -v flags from pickle cli #131068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

gh-93096: Remove -t and -v flags from pickle cli #131068

merged 2 commits into from
Mar 11, 2025

Conversation

donBarbos
Copy link
Contributor

@donBarbos donBarbos commented Mar 11, 2025 •
edited by bedevere-app bot
Loading

  • added load doctest to unittest
  • we still can run doctests using: ./python -m doctest Lib/pickle.py -v

@bedevere-app bedevere-app bot mentioned this pull request Mar 11, 2025
Open
27 tasks
vstinner
vstinner reviewed Mar 11, 2025
View reviewed changes
Lib/test/test_pickle.py Outdated
@@ -700,7 +700,7 @@ def test_multiprocessing_exceptions(self):


def load_tests(loader, tests, pattern):
tests.addTest(doctest.DocTestSuite())
tests.addTest(doctest.DocTestSuite(pickle))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this looks like a bugfix. It should be backported. Can you extract this change into a new PR? It's not directly related to CLI changes.

Copy link
Contributor Author

@donBarbos donBarbos Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure, should i open new issue or can i send PR for the current issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reuse the same issue.

vstinner
vstinner reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to document the current command line interface (CLI) in Doc/library/pickle.rst? https://docs.python.org/dev/library/pickle.html

@donBarbos
Copy link
Contributor Author

Would it be possible to document the current command line interface (CLI) in Doc/library/pickle.rst? https://docs.python.org/dev/library/pickle.html

I think it can be suggested in issue #130160

vstinner
vstinner approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka: Are you ok with these changes?

@vstinner
Copy link
Member

I think it can be suggested in issue #130160

You can reuse #93096 or create a new issue.

serhiy-storchaka
serhiy-storchaka approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 425e0af into python:main Mar 11, 2025
43 checks passed
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@donBarbos @seehwan80
pythongh-93096: Remove -t and -v flags from pickle cli (python#…
dce27bf 
…131068)

* Remove `python -m pickle -t`

* Revert adding doctest to unittests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donBarbos @vstinner @serhiy-storchaka