Skip to content

gh-93096: Load doctests in test_pickle #131069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

gh-93096: Load doctests in test_pickle #131069

merged 1 commit into from
Mar 11, 2025

Conversation

donBarbos
Copy link
Contributor

@donBarbos donBarbos commented Mar 11, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Mar 11, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 11, 2025
Open
27 tasks
@donBarbos
Copy link
Contributor Author

@vstinner ping to inform you

@vstinner vstinner added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 11, 2025
vstinner
vstinner approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

serhiy-storchaka
serhiy-storchaka approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 3bb20d1 into python:main Mar 11, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks @donBarbos for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2025
@donBarbos @miss-islington
pythongh-93096: Load doctests in test_pickle (pythonGH-131069)
56a609b 
Add doctests to unittest for `pickle`
(cherry picked from commit 3bb20d1)

Co-authored-by: donBarbos <donbarbos@proton.me>
@bedevere-app
Copy link

bedevere-app bot commented Mar 11, 2025

GH-131080 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 11, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2025
@donBarbos @miss-islington
pythongh-93096: Load doctests in test_pickle (pythonGH-131069)
952abef 
Add doctests to unittest for `pickle`
(cherry picked from commit 3bb20d1)

Co-authored-by: donBarbos <donbarbos@proton.me>
@bedevere-app
Copy link

bedevere-app bot commented Mar 11, 2025

GH-131081 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 11, 2025
serhiy-storchaka pushed a commit that referenced this pull request Mar 11, 2025
@miss-islington @donBarbos
[3.12] gh-93096: Fix loading doctests in test_pickle (GH-131069) (GH-…
bfad0b5 
…131081)

(cherry picked from commit 3bb20d1)

Co-authored-by: donBarbos <donbarbos@proton.me>
serhiy-storchaka pushed a commit that referenced this pull request Mar 11, 2025
@miss-islington @donBarbos
[3.13] gh-93096: Fix loading doctests in test_pickle (GH-131069) (GH-…
68a1591 
…131080)

(cherry picked from commit 3bb20d1)

Co-authored-by: donBarbos <donbarbos@proton.me>
@donBarbos donBarbos mentioned this pull request Mar 12, 2025
Merged
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@donBarbos @seehwan80
pythongh-93096: Load doctests in test_pickle (python#131069)
7823c06 
Add doctests to unittest for `pickle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donBarbos @vstinner @serhiy-storchaka