Skip to content

gh-130940: Modify default behavior of PyConfig.use_system_logger to enable on iOS #131172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Mar 12, 2025

#127592 added the PyConfig.use_system_logger configuration flag; this was backported to 3.13 in #127754.

This introduced an ABI breakage in 3.13.2; the flag will be removed from 3.13 by #131129.

However, the functional effect of the flag is required on iOS so that the logs generated by the simulator can be observed at all. As a general rule, there's very little reason you'd not want stdout and stderr routed to the system log on iOS - every BeeWare app, for example, includes std-nslog, which implements effectively the same behavior.

To allow for this, #131129 modifies the behavior on iOS to always use the system logger for stdout/stderr. This PR ensures that behaviour will be consistent by default between 3.13 and 3.14 - use of the system log is enabled by default on iOS, and disabled by default on macOS.


📚 Documentation preview 📚: https://cpython-previews--131172.org.readthedocs.build/

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 0f9661c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131172%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freakboy3742 freakboy3742 merged commit dd6d24e into python:main Mar 13, 2025
54 checks passed
@freakboy3742 freakboy3742 deleted the initconfig-system-log branch March 13, 2025 06:28
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
…er` to enable on iOS (python#131172)

Modify default behavior of use_system_log to enable on iOS.
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
…er` to enable on iOS (python#131172)

Modify default behavior of use_system_log to enable on iOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants