Skip to content

GH-131296: fix clang-cl warnings on Windows in blake2module.c #131299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2025
Merged

GH-131296: fix clang-cl warnings on Windows in blake2module.c #131299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Modules/blake2module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ void detect_cpu_features(cpu_flags *flags) {
ebx7 = info7[1];
ecx7 = info7[2];
edx7 = info7[3];
#else
#endif
(void) eax1; (void) ebx1; (void) ecx1; (void) edx1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL... definitely fighting against the compiler's idea of best practices here using useless no-op statements as a way to work around it. i wish we could disable a specific warning for a whole block of code. i feel like a future compiler will notice that these are useless and stop considering them a "use".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just the least minimal change to silence the warning :)

Luckily, I think we'll never have to fear that this will ever need a change: that (void) pattern is adapted by all known compilers for ages - and I think this will stay.

(void) eax7; (void) ebx7; (void) ecx7; (void) edx7;
#endif

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the double blank lines L98/L99 please? TiA


flags->avx = (ecx1 & ECX_AVX) != 0;

Expand Down
Loading