Skip to content

gh-131238: Remove pycore_runtime.h from pycore_pystate.h #131356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

gh-131238: Remove pycore_runtime.h from pycore_pystate.h #131356

merged 1 commit into from
Mar 19, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 17, 2025 •
edited
Loading

  • Remove includes from pycore_pystate.h:

    • pycore_runtime_structs.h
    • pycore_runtime.h
    • pycore_tstate.h
    • pycore_interp.h

  • Reorganize internal headers. Move _gc_thread_state from pycore_interp_structs.h to pycore_tstate.h.

  • Add 3 new header files to PCbuild/pythoncore.vcxproj

@bedevere-app bedevere-app bot mentioned this pull request Mar 17, 2025
Closed
@vstinner vstinner mentioned this pull request Mar 17, 2025
Merged
@vstinner
Copy link
Member Author

I wrote two PRs to prepare this one:

@markshannon
Copy link
Member

@vstinner why are you doing this right now? If it is so urgent, why did you not do it earlier?

This is creating a lot of churn and merge conflicts for my efforts to sort out the header files ##131351
which I need to fix actual issues around immortality #125174

@vstinner
Copy link
Member Author

@vstinner why are you doing this right now? If it is so urgent, why did you not do it earlier?

Hi, I always wanted to reorganize pycore headers mess, and your issue was a good motivation to work on it. I waited until you merged your PR before pushing my changes. I didn't know that you have further changes in the queue. I will stop for now until you're done to avoid further conflicts.

@vstinner vstinner marked this pull request as draft March 17, 2025 11:57
@markshannon
Copy link
Member

markshannon commented Mar 17, 2025 •
edited
Loading

Hi, I always wanted to reorganize pycore headers mess, and your issue was a good motivation to work on it.

Glad to be a motivation 🙂

I waited until you merged your PR before pushing my changes. I didn't know that you have further changes in the queue. I will stop for now until you're done to avoid further conflicts.

Thanks. I'll let you know I'm done.

@vstinner
pythongh-131238: Remove pycore_runtime.h from pycore_pystate.h
aedc7f0 
* Remove includes from pycore_pystate.h:

  * pycore_runtime_structs.h
  * pycore_runtime.h
  * pycore_tstate.h
  * pycore_interp.h

* Reorganize internal headers. Move _gc_thread_state from
  pycore_interp_structs.h to pycore_tstate.h.
* Add 3 new header files to PCbuild/pythoncore.vcxproj
@vstinner vstinner marked this pull request as ready for review March 19, 2025 16:32
@vstinner vstinner merged commit 4b54031 into python:main Mar 19, 2025
43 checks passed
@vstinner vstinner deleted the pycore_deps6 branch March 19, 2025 16:33
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@vstinner @seehwan80
pythongh-131238: Remove pycore_runtime.h from pycore_pystate.h (pytho…
a08f270 
…n#131356)

* Remove includes from pycore_pystate.h:

  * pycore_runtime_structs.h
  * pycore_runtime.h
  * pycore_tstate.h
  * pycore_interp.h

* Reorganize internal headers. Move _gc_thread_state from
  pycore_interp_structs.h to pycore_tstate.h.
* Add 3 new header files to PCbuild/pythoncore.vcxproj.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @markshannon