GH-131296: fix clang-cl warning on Windows in _wmimodule.cpp #131587
Conversation
| @@ -240,7 +240,6 @@ _wmi_exec_query_impl(PyObject *module, PyObject *query) | |||
|
|
|||
| /*[clinic end generated code]*/ | |||
| { | |||
| PyObject *result = NULL; | |||
There was a problem hiding this comment.
fix warning : unused variable 'result' [-Wunused-variable]
|
@chris-eibl Just FYI, I'm rewriting a lot of your PR titles when we commit. It's not a problem - part of what we do as core devs - but you probably haven't noticed, so figured I'd mention it in case you wanted to check them. It's unfortunate that they follow the PR title by default, because your PR titles are fine. But commit messages are more likely to be read without context (in this case, without timeliness - they'll be read in the future when there isn't a flurry of clang-cl warnings being dealt with), so we tend to go a bit more neutral with them. |
|
Yeah - sure. I am reading for quite some time here, so I am familiar with having modified commit messages when merging upstream - for exactly that reason. Big +1 from me :) |
I think this is a skip news?