Skip to content

GH-131678: fix Windows tail-call CI does not run the test cases #131690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2025
Merged

GH-131678: fix Windows tail-call CI does not run the test cases #131690

merged 2 commits into from
Mar 28, 2025
+2 −2

Conversation

chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Mar 24, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 24, 2025
Closed
@chris-eibl
Copy link
Member Author

I think this is a skip news?

@hugovk
Copy link
Member

hugovk commented Mar 25, 2025 •
edited
Loading

Yes, label added.

Thanks for the PR!

Although test_mmap is failing, let's deal with that first, cc @Fidget-Spinner.

@chris-eibl
Copy link
Member Author

chris-eibl commented Mar 25, 2025 •
edited
Loading

Yeah, I have already created an issue for the failing test #131691

@chris-eibl
Copy link
Member Author

#131691 was fixed and merged (in case this was blocking).

IMHO, this is good to merge: it now runs the test cases - and they are green?

@Fidget-Spinner Fidget-Spinner merged commit ce77da5 into python:main Mar 28, 2025
44 checks passed
@chris-eibl chris-eibl deleted the windows_tail_call_yml branch March 28, 2025 15:07
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@chris-eibl @seehwan80
pythonGH-131678: fix Windows tail-call CI does not run the test cases (…
90b4973 
…pythonGH-131690)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-eibl @hugovk @Fidget-Spinner