Skip to content

gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier #131830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 4, 2025
+59 −57
Merged

gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier #131830

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
678b085
rename ast_opt.c -> ast_process.c
WolframAlph Mar 28, 2025
e080e27
_PyASTOptimizeState -> _PyASTProcessState
WolframAlph Mar 28, 2025
5153ea5
_PyAST_Optimize -> _PyAST_Process
WolframAlph Mar 28, 2025
ad5d080
_PyCompile_AstOptimize -> _PyCompile_AstProcess
WolframAlph Mar 28, 2025
3a6abef
add news
WolframAlph Mar 28, 2025
e2a3cbc
address review
WolframAlph Mar 28, 2025
2d1bc6f
mention full file path
WolframAlph Mar 28, 2025
3b43460
rename process to preprocess
WolframAlph May 4, 2025
72cca4f
_PyASTProcessState -> _PyASTPreprocessState
WolframAlph May 4, 2025
8a59650
update comment
WolframAlph May 4, 2025
a30846d
Merge branch 'main' into rename-ast-opt
Eclips4 May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
_PyCompile_AstOptimize -> _PyCompile_AstProcess
  • Loading branch information
@WolframAlph
WolframAlph committed May 4, 2025
commit ad5d0809637a721a2efdb37ab843bfaebbf3a8eb
4 changes: 2 additions & 2 deletions Include/internal/pycore_compile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ PyAPI_FUNC(PyCodeObject*) _PyAST_Compile(
int optimize,
struct _arena *arena);

/* AST optimizations */
extern int _PyCompile_AstOptimize(
/* AST processing */
extern int _PyCompile_AstProcess(
struct _mod *mod,
PyObject *filename,
PyCompilerFlags *flags,
Expand Down
2 changes: 1 addition & 1 deletion Python/bltinmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ builtin_compile_impl(PyObject *module, PyObject *source, PyObject *filename,
goto error;
}
int syntax_check_only = ((flags & PyCF_OPTIMIZED_AST) == PyCF_ONLY_AST); /* unoptiomized AST */
if (_PyCompile_AstOptimize(mod, filename, &cf, optimize,
if (_PyCompile_AstProcess(mod, filename, &cf, optimize,
arena, syntax_check_only) < 0) {
_PyArena_Free(arena);
goto error;
Expand Down
2 changes: 1 addition & 1 deletion Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,7 +1481,7 @@ _PyAST_Compile(mod_ty mod, PyObject *filename, PyCompilerFlags *pflags,
}

int
_PyCompile_AstOptimize(mod_ty mod, PyObject *filename, PyCompilerFlags *cf,
_PyCompile_AstProcess(mod_ty mod, PyObject *filename, PyCompilerFlags *cf,
int optimize, PyArena *arena, int no_const_folding)
{
_PyFutureFeatures future;
Expand Down
2 changes: 1 addition & 1 deletion Python/pythonrun.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1498,7 +1498,7 @@ Py_CompileStringObject(const char *str, PyObject *filename, int start,
}
if (flags && (flags->cf_flags & PyCF_ONLY_AST)) {
int syntax_check_only = ((flags->cf_flags & PyCF_OPTIMIZED_AST) == PyCF_ONLY_AST); /* unoptiomized AST */
if (_PyCompile_AstOptimize(mod, filename, flags, optimize, arena, syntax_check_only) < 0) {
if (_PyCompile_AstProcess(mod, filename, flags, optimize, arena, syntax_check_only) < 0) {
_PyArena_Free(arena);
return NULL;
}
Expand Down