Skip to content

gh-128438: Use EnvironmentVarGuard for test_zoneinfo.py to manage environmen… #131870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2025
Merged

gh-128438: Use EnvironmentVarGuard for test_zoneinfo.py to manage environmen… #131870

merged 1 commit into from
Apr 27, 2025

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Mar 29, 2025 •
edited
Loading

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Mar 29, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 29, 2025
Open
@picnixz picnixz assigned picnixz and unassigned picnixz Mar 29, 2025
@picnixz picnixz self-requested a review March 29, 2025 10:03
@picnixz picnixz requested review from Eclips4 and removed request for picnixz March 29, 2025 10:04
@Wulian233 Wulian233 mentioned this pull request Apr 5, 2025
Closed
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@Wulian233
Copy link
Contributor Author

@picnixz @Eclips4 This PR is now ready for review. There's no need to worry about thread safety issues. Previously, it was discussed at #132113 ❤️

@picnixz picnixz self-assigned this Apr 24, 2025
@picnixz picnixz merged commit 8b4fd24 into python:main Apr 27, 2025
48 checks passed
@Wulian233 Wulian233 deleted the test_zoneinfo branch April 27, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@Eclips4 Eclips4 Awaiting requested review from Eclips4

Assignees

@picnixz picnixz

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wulian233 @picnixz