GH-131296: move suppression of "unused label" warning for clang-cl on Windows #131900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from global pyproject-clangcl.props to ceval.c
chris-eibl
commented
Mar 30, 2025
| @@ -898,7 +898,7 @@ extern void _PyUOpPrint(const _PyUOpInstruction *uop); | |||
| if computed gotos aren't used. */ | |||
|
|
|||
| /* TBD - what about other compilers? */ | |||
| #if defined(__GNUC__) | |||
| #if defined(__GNUC__) || defined(__clang__) | |||
There was a problem hiding this comment.
On Windows, clang-cl does not define __GNUC__ (in contrast to Linux), so let's add __clang__ here.
Slightly further down, for MSVC the same warning (4102) is suppressed using #pragma warning(disable:4102), which clang-cl unfortunately does not understand (yet).
The only occurrences of this warning in the whole code base stem from "generated_cases.c.h", so this is a better place to suppress it in case of clang-cl, instead of doing it globally via pyproject-clangcl.props.
chris-eibl
commented
Mar 30, 2025
| @@ -46,7 +46,7 @@ | |||
| Please see GH-131691 for details. | |||
| --> | |||
| <ExceptionHandling>Async</ExceptionHandling> | |||
| <AdditionalOptions>-Wno-deprecated-non-prototype -Wno-unused-label -Wno-pointer-sign -Wno-incompatible-pointer-types-discards-qualifiers -Wno-unused-function %(AdditionalOptions)</AdditionalOptions> | |||
| <AdditionalOptions>-Wno-pointer-sign -Wno-incompatible-pointer-types-discards-qualifiers -Wno-unused-function %(AdditionalOptions)</AdditionalOptions> | |||
There was a problem hiding this comment.
-Wno-unused-label is moved to ceval.c.
-Wno-deprecated-non-prototype is removed, because it does not "fire" for the whole code base.
|
Failing of |
I'm busy right now but from the brief look I did, it seems homebrew changed the directory of where clang 19 is installed. I can only fix it tomorrow, but if you want to take a try you can fix the directory in the CI file today #131895 (comment) |
|
All commit authors signed the Contributor License Agreement. |
|
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…to actual occurrence (pythonGH-131900)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a skip news?