gh-131938: Update error message for Element.remove() when an element is not found
#131972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vstinner You suggested this in the other PR, but I don't know if you want me to align the Python implementation as well. More generally, what's the policy when we have a C and a Python implementation: should the exception messages match as much as possible or is it fine to have discrepencies? |
vstinner
reviewed
Apr 1, 2025
picnixz
commented
Apr 1, 2025
vstinner
reviewed
Apr 1, 2025
Co-authored-by: Victor Stinner <vstinner@python.org>
|
I'm actually leaving now so won't have time to push this, I'll do it on Friday though! |
|
The Windows x64 job failed with a network issue (urllib.error.HTTPError: HTTP Error 504: Gateway Timeout). I restarted the job. |
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
… an element is not found (python#131972) The exception message for `xml.etree.ElementTree.Element.remove` when an element is not found has been updated from "list.remove(x): x not in list" to "Element.remove(x): element not found".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element.removeexception message when an element is not found #131938