gh-85302: Add support for BTPROTO_SCO on FreeBSD #131981
Conversation
BTPROTO_SCO has been supported on FreeBSD since 2008.
|
!buildbot FreeBSD |
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 2debf1e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
With this change, socket.BTPROTO_SCO constant does not exist on FreeBSD which makes the whole change useless.
The problem is that on my FreeBSD 14.1 VM, the constant is not defined anywhere.grep finds nothing:
$ grep BTPROTO_SCO /usr/include/ -R
Are you sure that FreeBSD supports BTPROTO_SCO?
|
Indeed, it is defined as BLUETOOTH_PROTO_SCO. I'll fix this, but first we need to add tests. See #132023. |
|
!buildbot FreeBSD |
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 2debf1e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
You need to update your PR to use BLUETOOTH_PROTO_SCO constant, no? |
|
Did I forget to push my changes? Thanks for noticing. |
|
!buildbot FreeBSD |
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit a62570a 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
All commit authors signed the Contributor License Agreement. |
BTPROTO_SCO has been supported on FreeBSD since 2008.
📚 Documentation preview 📚: https://cpython-previews--131981.org.readthedocs.build/