gh-131544: Update docs for PyType_AddWatcher #132015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason why we decided to update the documentation: #131544 (comment) |
vstinner
reviewed
Apr 2, 2025
Doc/c-api/type.rst
Outdated
| @@ -82,6 +82,9 @@ Type Objects | |||
| error (e.g. no more watcher IDs available), return ``-1`` and set an | |||
| exception. | |||
|
|
|||
| In free-threaded builds, :c:func:`PyType_AddWatcher` is not thread-safe, | |||
| so it must be called at start up. | |||
There was a problem hiding this comment.
maybe: "so it must be called at start up (before spawning the first thread)."
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2025
(cherry picked from commit 25275bd) Co-authored-by: Donghee Na <donghee.na@python.org>
|
GH-132019 is a backport of this pull request to the 3.13 branch. |
corona10
added a commit
that referenced
this pull request
Apr 2, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyType_AddWatcherand friends are not thread safe in free-threading #131544📚 Documentation preview 📚: https://cpython-previews--132015.org.readthedocs.build/