Skip to content

gh-119605: Respect follow_wrapped for __init__ and __new__ when getting class signature with inspect.signature #132055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
May 1, 2025
Merged

gh-119605: Respect follow_wrapped for __init__ and __new__ when getting class signature with inspect.signature #132055

merged 36 commits into from
May 1, 2025

Conversation

XuehaiPan
Copy link
Contributor

@XuehaiPan XuehaiPan commented Apr 3, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 3, 2025
Open
@XuehaiPan XuehaiPan force-pushed the deprecated-signature branch from 2758c37 to aa8865e Compare April 3, 2025 17:18
@XuehaiPan XuehaiPan marked this pull request as ready for review April 3, 2025 17:45
@XuehaiPan
Copy link
Contributor Author

cc @JelleZijlstra

skirpichev
skirpichev reviewed Apr 4, 2025
View reviewed changes
JelleZijlstra
JelleZijlstra reviewed Apr 4, 2025
View reviewed changes
@XuehaiPan XuehaiPan requested a review from JelleZijlstra April 4, 2025 15:43
XuehaiPan
XuehaiPan commented Apr 4, 2025
View reviewed changes
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

JelleZijlstra
JelleZijlstra requested changes Apr 6, 2025
View reviewed changes
@XuehaiPan XuehaiPan requested a review from JelleZijlstra April 6, 2025 15:34
@XuehaiPan XuehaiPan changed the title gh-119605: Preserve class signature after wrapping with @warnings.deprecated gh-119605: Respect follow_wrapped for __init__ and __new__ when getting class signature with inspect.signature Apr 6, 2025
@XuehaiPan XuehaiPan mentioned this pull request Apr 6, 2025
Closed
@XuehaiPan
Copy link
Contributor Author

cc @serhiy-storchaka for code review

@JelleZijlstra JelleZijlstra added the needs backport to 3.13 bugs and security fixes label May 1, 2025
@JelleZijlstra JelleZijlstra merged commit b8633f9 into python:main May 1, 2025
44 of 45 checks passed
@miss-islington-app
Copy link

Thanks @XuehaiPan for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 1, 2025
@XuehaiPan @miss-islington
pythongh-119605: Respect follow_wrapped for __init__ and `__new__…
ae58ecb 
…` when getting class signature with `inspect.signature` (pythonGH-132055)

(cherry picked from commit b8633f9)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
@bedevere-app
Copy link

bedevere-app bot commented May 1, 2025

GH-133277 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 1, 2025
JelleZijlstra pushed a commit that referenced this pull request May 2, 2025
@miss-islington @XuehaiPan
[3.13] gh-119605: Respect follow_wrapped for __init__ and `__new_…
766c5f7 
…_` when getting class signature with `inspect.signature` (GH-132055) (#133277)

gh-119605: Respect `follow_wrapped` for `__init__` and `__new__` when getting class signature with `inspect.signature` (GH-132055)
(cherry picked from commit b8633f9)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuehaiPan @JelleZijlstra @skirpichev