Skip to content

gh-100239: more refined specialisation stats for BINARY_OP/SUBSCR #132068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

gh-100239: more refined specialisation stats for BINARY_OP/SUBSCR #132068

merged 2 commits into from
Apr 4, 2025

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Apr 4, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 4, 2025
Open
@iritkatriel iritkatriel requested a review from markshannon April 4, 2025 10:56
markshannon
markshannon approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

It would be nice to gather the type information we want in a more general way, but I don't see how to do that without adding a lot more complexity.
Maybe one day, but this is just fine for now.

@iritkatriel iritkatriel merged commit df59226 into python:main Apr 4, 2025
49 checks passed
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@iritkatriel @seehwan80
pythongh-100239: more refined specialisation stats for BINARY_OP/SUBS…
8e028f8 
…CR (python#132068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iritkatriel @markshannon