Skip to content

GH-131498: manage stacks automatically #132074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 4, 2025
Merged

GH-131498: manage stacks automatically #132074

merged 10 commits into from
Apr 4, 2025

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Apr 4, 2025 •
edited by bedevere-app bot
Loading

This is the final preparatory PR for top-of-stack caching

This PR:

  • Removes the stack manipulation macros. Instructions must declare values as dead, and let the code generator pop them from the stack
  • Updates the instrumented instructions to be explicit about their stack effect
  • Supports mixing of scalars and arrays on the stack. The code generator pushes scalars to memory if needed for an array.

@bedevere-app bedevere-app bot mentioned this pull request Apr 4, 2025
Open
StanFromIreland
StanFromIreland reviewed Apr 4, 2025
View reviewed changes
StanFromIreland
StanFromIreland reviewed Apr 4, 2025
View reviewed changes
@markshannon @StanFromIreland
Apply suggestions from code review
4f8fa37 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@markshannon
Copy link
Member Author

markshannon commented Apr 4, 2025 •
edited
Loading

The MSVC tail calling interpreter failure seems unrelated to this PR.

@markshannon markshannon merged commit 7099c75 into python:main Apr 4, 2025
70 of 71 checks passed
@markshannon markshannon deleted the code-gen-handle-stacks branch April 4, 2025 17:09
picnixz pushed a commit to picnixz/cpython that referenced this pull request Apr 5, 2025
@markshannon @picnixz
pythonGH-131498: Cases generator: manage stacks automatically (python…
0b437c4 
…GH-132074)
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@markshannon @seehwan80
pythonGH-131498: Cases generator: manage stacks automatically (python…
8b7160f 
…GH-132074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@iritkatriel iritkatriel iritkatriel approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markshannon @iritkatriel @StanFromIreland