gh-126703: Fix possible use after free in pycfunction freelist #132319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Fidget-Spinner
commented
Apr 9, 2025
•
- Issue: Use freelist for range object, iterator objects and other often used objects #126703
|
@hawkinsp does this look right to you? |
hawkinsp
reviewed
Apr 9, 2025
Objects/methodobject.c
Outdated
| @@ -173,12 +173,16 @@ meth_dealloc(PyObject *self) | |||
| if (m->m_weakreflist != NULL) { | |||
| PyObject_ClearWeakRefs((PyObject*) m); | |||
| } | |||
| // We need to access ml_flags here rather than later. | |||
| // `m` might have the same lifetime | |||
There was a problem hiding this comment.
m->m_ml I think here, but yes.
You are also right that probably we should update the API documentation to clarify this is an acceptable thing to do.
hawkinsp
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.