gh-132316: Require socket and GITHUB_TOKEN env to use GitHubArtifactDatabase
#132348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubArtifactDatabase`
hugovk
approved these changes
Apr 10, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @sobolevn, I could not cleanly backport this to |
|
Let's skip it if not needed. It can always be updated later. |
|
I wouldn't mind getting this backported into 3.13 since that is the version we found it in :). But we can certainly vendor the patch if necessary. |
|
@hugovk let's then backport both PRs maybe? |
|
Sure! Can you take care of it? |
|
Will do :) |
This was referenced Apr 10, 2025
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 10, 2025
…ubArtifactDatabase` (pythonGH-132348) (cherry picked from commit fcf2d07) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-132367 is a backport of this pull request to the 3.13 branch. |
|
Thanks @sobolevn! Tests with latest 3.13 bits are green again. |
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…ubArtifactDatabase` (python#132348) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not check for enabled resources, because this is a local build.