Skip to content

[3.13] gh-130834: Fix free-threaded build with JIT for aarch64 linux #132368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

[3.13] gh-130834: Fix free-threaded build with JIT for aarch64 linux #132368

merged 2 commits into from
Apr 11, 2025
+6 −1

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Apr 10, 2025 •
edited by bedevere-app bot
Loading

@corona10 corona10 requested a review from brandtbucher as a code owner April 10, 2025 14:56
@corona10 corona10 requested review from savannahostrowski and brandtbucher and removed request for brandtbucher April 10, 2025 14:56
@bedevere-app bedevere-app bot mentioned this pull request Apr 10, 2025
Closed
@corona10 corona10 requested a review from diegorusso April 10, 2025 14:56
@corona10 corona10 changed the title [3.13] gh-130834: Fix free-threaded build with JIT for arm [3.13] gh-130834: Fix free-threaded build with JIT for aarch64 Apr 10, 2025
@corona10 corona10 changed the title [3.13] gh-130834: Fix free-threaded build with JIT for aarch64 [3.13] gh-130834: Fix free-threaded build with JIT for aarch64 linux Apr 10, 2025
diegorusso
diegorusso approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@diegorusso diegorusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@corona10
Copy link
Member Author

corona10 commented Apr 10, 2025 •
edited
Loading

Failure is unrelated to this PR: https://github.com/python/cpython/actions/runs/14290676125/job/40140206754 (Similar failure from the previous commits cc @diegorusso )

@diegorusso
Copy link
Contributor

diegorusso commented Apr 10, 2025 •
edited
Loading

Failure is unrelated to this PR: https://github.com/python/cpython/actions/runs/14290676125/job/40140206754 (Similar failure from the previous commits cc @diegorusso )

On 3.13 we still run AARch64 in emulation. I'm not sure if this could be the cause of the failure. I'm re-running the job.

@corona10
Copy link
Member Author

I'm not sure if this could be the cause of the failure.

Yeah, I think it's not. It already happens at #131749

@corona10 corona10 merged commit 793293d into python:3.13 Apr 11, 2025
66 of 67 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO + PGO 3.13 (tier-2) has failed when building commit 793293d.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1433/builds/644) and take a look at the build logs.
  4. Check if the failure is related to this commit (793293d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1433/builds/644

Failed tests:

  • test_perf_profiler

Failed subtests:

  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/test_perf_profiler.py", line 356, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python_98t8t40x/tmpk4nivigi/perftest.py' not found in 'python 2143782 1542860.251355:          1 cycles:Pu: \n\t    ffff8f453ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2143782 1542860.251388:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffff8f453ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2143782 1542860.252083:          1 cycles:Pu: \n\tffffaa282d37f654 [unknown] ([unknown])\n\tffffaa282d380484 [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffff8f456398 strcmp+0x98 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f43fc03 _dl_map_object_from_fd+0xf23 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f440133 _dl_map_object+0x1e7 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f43b5bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f43a303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f43bb33 _dl_map_object_deps+0x553 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f45119f dl_main+0x139f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f44e5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f44fb17 _dl_start_final+0x5ab (inlined)\n\t    ffff8f44fb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f453ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2143782 1542860.252116:        288 cycles:Pu: \n\t    ffff8f45639c strcmp+0x9c (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f43fc03 _dl_map_object_from_fd+0xf23 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f440133 _dl_map_object+0x1e7 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f43b5bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f43a303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8f43bb33 _dl_map_object_de
arch64.lto-pgo/build/python)\n\t          576f67 pymain_init+0x3b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576eb3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576e23 Py_BytesMain+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t    ffff8f1e625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff8f1e633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          575a6f _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\npython 2143782 1542860.254158:      60133 cycles:Pu: \n\t    ffff8f25be38 _int_malloc+0x238 (/usr/lib64/libc.so.6)\n\t    ffff8f25d5cb malloc+0x22b (/usr/lib64/libc.so.6)\n\t          47e20f _Py_hashtable_set+0x14f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5816ab intern_static.isra.0+0x43 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          580c1b _PyUnicode_InternStatic+0x237b (inlined)\n\t          580c1b init_global_interned_strings+0x237b (inlined)\n\t          580c1b _PyUnicode_InitGlobalObjects+0x237b (inlined)\n\t          580c1b pycore_init_global_objects+0x237b (inlined)\n\t          580c1b pycore_interp_init+0x237b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          579173 pyinit_config+0x413 (inlined)\n\t          579173 pyinit_core.constprop.0+0x413 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578cc3 Py_InitializeFromConfig+0x33 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576fef pymain_init+0xc3 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576eb3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576e23 Py_BytesMain+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t    ffff8f1e625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff8f1e633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          575a6f _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\npython 2143782 1542860.254702:     584623 cycles:Pu: \n\t          582b38 add_operators+0x174 (inlined)\n\t          582b38 type_ready_fill_dict+0x174 (inlined)\n\t          582b38 type_ready+0x174 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          58289f init_static_type+0xbf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          581e2f _PyTypes_InitTypes+0x43 (inlined)\n\t          581e2f pycore_init_types+0x43 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          580d6b pycore_interp_init+0x24cb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          579173 pyinit_config+0x413 (inlined)\n\t          579173 pyinit_core.constprop.0+0x413 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578cc3 Py_InitializeFromConfig+0x33 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576fef pymain_init+0xc3 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576eb3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576e23 Py_BytesMain+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t    ffff8f1e625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff8f1e633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          575a6f _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\npyth


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/test_perf_profiler.py", line 356, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python_ktk417rn/tmp4l64olqy/perftest.py' not found in 'python 2169115 1542954.787838:          1 cycles:Pu: \n\t    ffff8fc02ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2169115 1542954.787870:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffff8fc02ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2169115 1542954.788091:          1 cycles:Pu: \n\t    ffff8fbfa504 _dl_audit_objopen+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8fc00177 dl_main+0x1377 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8fbfd5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8fbfeb17 _dl_start_final+0x5ab (inlined)\n\t    ffff8fbfeb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8fc02ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2169115 1542954.788112:        293 cycles:Pu: \n\t    ffff8fbea600 _dl_map_object_deps+0x20 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8fc0019f dl_main+0x139f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8fbfd5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8fbfeb17 _dl_start_final+0x5ab (inlined)\n\t    ffff8fbfeb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8fc02ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2169115 1542954.789196:       1929 cycles:Pu: \n\t    ffff8fa136e4 strcmp+0x24 (/usr/lib64/libc.so.6)\n\t    ffff8f9a1657 _nl_load_locale_from_archive+0x1b7 (/usr/lib64/libc.so.6)\n\t    ffff8f9a0c7f _nl_find_locale+0xff (/usr/lib64/libc.so.6)\n\t    ffff8f9a344f setlocale+0x3cf (/usr/lib64/libc.so.6)\n\t          578237 _Py_SetLocaleFromEnv+0x13 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5775eb _PyPreConfig_Read+0x10b (inlined)\n\t          5775eb _Py_PreInitializeFromPyArgv+0x10b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576f67 pymain_init+0x3b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576eb3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576e23 Py_BytesMain+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t    ffff8f99625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff8f99633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          575a6f _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\npython 2169115 1542954.789376:     104496 cycles:Pu: \n\t    ffff8fbeffd0 do_lookup_x+0x350 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8fbf0833 _dl_lookup_symbol_x+0x113 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8fbf5a5b _dl_fixup+0xfb (/usr/lib/l
dict+0x2bf (inlined)\n\t          582c83 type_ready+0x2bf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          58289f init_static_type+0xbf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          581e2f _PyTypes_InitTypes+0x43 (inlined)\n\t          581e2f pycore_init_types+0x43 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          580d6b pycore_interp_init+0x24cb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          579173 pyinit_config+0x413 (inlined)\n\t          579173 pyinit_core.constprop.0+0x413 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578cc3 Py_InitializeFromConfig+0x33 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576fef pymain_init+0xc3 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576eb3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576e23 Py_BytesMain+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t    ffff8f99625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff8f99633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          575a6f _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\npython 2169115 1542954.791224:    1599419 cycles:Pu: \n\t    ffff8fa1ac14 __strlen_asimd+0x14 (/usr/lib64/libc.so.6)\n\t          48358b PyUnicode_FromString+0x8b (inlined)\n\t          48358b PyUnicode_InternFromString+0x8b (inlined)\n\t          48358b descr_new+0x8b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          486a23 PyDescr_NewMethod+0x43 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          585c57 type_add_method+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          5834b3 type_add_methods+0xaef (inlined)\n\t          5834b3 type_ready_fill_dict+0xaef (inlined)\n\t          5834b3 type_ready+0xaef (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          58289f init_static_type+0xbf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          581e2f _PyTypes_InitTypes+0x43 (inlined)\n\t          581e2f pycore_init_types+0x43 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          580d6b pycore_interp_init+0x24cb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          579173 pyinit_config+0x413 (inlined)\n\t          579173 pyinit_core.constprop.0+0x413 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          578cc3 Py_InitializeFromConfig+0x33 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576fef pymain_init+0xc3 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576eb3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          576e23 Py_BytesMain+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t    ffff8f99625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff8f99633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          575a6f _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\npython 2169115 1542954.794008:    5223593 cycles:Pu: \n\t          483120 insert_to_emptydict+0x150 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/python)\n\t          489e4b setitem_take2_lock_held+0x4ab (inlined)\n\t          489e4b setitem_lock_held+0x4ab (inlined)\n\t          489e4b _PyDict_SetItem_LockHeld+0x4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegorusso diegorusso diegorusso approved these changes

@savannahostrowski savannahostrowski savannahostrowski approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @diegorusso @bedevere-bot @savannahostrowski