gh-100239: specialize dict subclasses with no getitem override #132383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests will be great again once we merge the fix for #132284. |
Python/bytecodes.c
Outdated
| @@ -971,15 +971,14 @@ dummy_func( | |||
| PyObject *sub = PyStackRef_AsPyObjectBorrow(sub_st); | |||
| PyObject *dict = PyStackRef_AsPyObjectBorrow(dict_st); | |||
|
|
|||
| assert(PyDict_CheckExact(dict)); | |||
| assert(PyDict_Check(dict)); | |||
There was a problem hiding this comment.
I think you also need to change _GUARD_NOS_DICT to PyDict_Check instead of PyDict_CheckExact for this to work but I am not sure.
There was a problem hiding this comment.
It does look like it from the code, but I don't see more misses.
|
Perf with the fix to the guard: https://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20250412-3.14.0a7%2B-3d9cf36/README.md |
markshannon
reviewed
Apr 14, 2025
methane
approved these changes
Apr 15, 2025
markshannon
reviewed
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perf stats show the specialisation numbers improve, but perf is overall the same.
https://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20250410-3.14.0a6%2B-bf2d1dd/README.md