gh-132385: Fix instance error suggestions potential exceptions in traceback
#132387
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
reviewed
Apr 11, 2025
Lib/traceback.py
Outdated
| if hasattr(self, wrong_name): | ||
| try: | ||
| has_wrong_name = hasattr(self, wrong_name) | ||
| except BaseException: |
There was a problem hiding this comment.
This can swallow things like KeyboardInterrupt and MemoryError. We shouldn't do that.
There was a problem hiding this comment.
No :)
>>> SystemExit.__mro__
(<class 'SystemExit'>, <class 'BaseException'>, <class 'object'>)|
After this change: 2025-04-11.13.45.38.mov |
iritkatriel
reviewed
May 1, 2025
| if hasattr(self, wrong_name): | ||
| try: | ||
| has_wrong_name = hasattr(self, wrong_name) | ||
| except Exception: |
There was a problem hiding this comment.
Why do we need to handle exceptions here? hasattr returns a boolean.
There was a problem hiding this comment.
Because hasattr triggers __getattr__ which can raise an exception. If it raises - the whole repl process will fail with an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not cover all side-effects, it will still evaluate
print, etc.But, it does not fail with exceptions at least.
__getattr__#132385