Skip to content

gh-132386: Fix a crash when passing a dict subclass to exec #132412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

gh-132386: Fix a crash when passing a dict subclass to exec #132412

merged 2 commits into from
Apr 11, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Apr 11, 2025 •
edited by bedevere-app bot
Loading

This issue boils down to a different branch being taken in _PyEval_LoadGlobalStackRef when a dict subclass is passed to exec globals. There is one case where the stack ref is not set to PyStackRef_NULL which causes the abort.

@tomasr8 tomasr8 requested a review from markshannon as a code owner April 11, 2025 17:01
@bedevere-app bedevere-app bot mentioned this pull request Apr 11, 2025
Closed
@tomasr8 tomasr8 requested a review from Fidget-Spinner April 11, 2025 20:29
@Fidget-Spinner Fidget-Spinner merged commit e6ef47a into python:main Apr 11, 2025
54 checks passed
@tomasr8 tomasr8 deleted the fix-exec-dict-subclass branch April 11, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasr8 @Fidget-Spinner