Skip to content

GH-90812: Add test for urlopen() of file URI for UNC path #132489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

GH-90812: Add test for urlopen() of file URI for UNC path #132489

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9e0939
GH-90812: Add test for `urlopen()` of file URI for UNC path
barneygale Apr 14, 2025
5b507b9
Fix test
barneygale Apr 14, 2025
d86cbc6
Don't test localised OS error string
barneygale Apr 14, 2025
36adb8a
Merge branch 'main' into gh-90812
barneygale Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Lib/test/test_urllib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,16 @@ def test_iter(self):
def test_relativelocalfile(self):
self.assertRaises(ValueError,urllib.request.urlopen,'./' + self.pathname)

def test_remote_authority(self):
# Test for GH-90812.
url = 'file://pythontest.net/foo/bar'
with self.assertRaises(urllib.error.URLError) as e:
urllib.request.urlopen(url)
if os.name == 'nt':
self.assertEqual(e.exception.filename, r'\\pythontest.net\foo\bar')
else:
self.assertEqual(e.exception.reason, 'file:// scheme is supported only on localhost')


class ProxyTests(unittest.TestCase):

Expand Down
Loading