Skip to content

gh-132515: de-duplicate test_dataclass_derived_generic_from_slotted_base #132516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

gh-132515: de-duplicate test_dataclass_derived_generic_from_slotted_base #132516

merged 1 commit into from
Apr 14, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Apr 14, 2025 •
edited by bedevere-app bot
Loading

@picnixz picnixz requested a review from ericvsmith as a code owner April 14, 2025 14:41
@bedevere-app bedevere-app bot mentioned this pull request Apr 14, 2025
Closed
@picnixz picnixz mentioned this pull request Apr 14, 2025
Merged
@picnixz picnixz enabled auto-merge (squash) April 14, 2025 14:44
@picnixz picnixz added needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes labels Apr 14, 2025
@picnixz
Copy link
Member Author

picnixz commented Apr 14, 2025 •
edited
Loading

(The test only exists since fa9b9cb).

GH is a bit ... lying. I thought it would have shown that it's in 3.13 as well but apparently it didn't detect as such.

@picnixz picnixz added the needs backport to 3.13 bugs and security fixes label Apr 14, 2025
@picnixz picnixz merged commit 45c447b into python:main Apr 14, 2025
54 checks passed
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 14, 2025
@picnixz @miss-islington
pythongh-132515: de-duplicate `test_dataclass_derived_generic_from_sl…
7c5c53a 
…otted_base` (pythonGH-132516)

(cherry picked from commit 45c447b)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz picnixz deleted the fix/tests/dataclass-duplicated-test-132515 branch April 14, 2025 15:06
@bedevere-app
Copy link

bedevere-app bot commented Apr 14, 2025

GH-132518 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 14, 2025
picnixz added a commit that referenced this pull request Apr 14, 2025
@miss-islington @picnixz
[3.13] gh-132515: de-duplicate `test_dataclass_derived_generic_from_s…
a50aa33 
…lotted_base` (GH-132516) (#132518)

gh-132515: de-duplicate `test_dataclass_derived_generic_from_slotted_base` (GH-132516)
(cherry picked from commit 45c447b)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees
No one assigned
Labels
skip news topic-dataclasses
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@picnixz