Skip to content

Revert "gh-128384: Use a context variable for warnings.catch_warnings (gh-130010) #132601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 16, 2025

This reverts commit d687900.

Draft to test if revert fixes buildbots.


📚 Documentation preview 📚: https://cpython-previews--132601.org.readthedocs.build/

@hugovk
Copy link
Member Author

hugovk commented Apr 16, 2025

!buildbot AMD64 CentOS9 NoGIL Refleaks

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 32104a3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132601%2Fmerge

The command will test the builders whose names match following regular expression: AMD64 CentOS9 NoGIL Refleaks

The builders matched are:

  • AMD64 CentOS9 NoGIL Refleaks PR

@hugovk
Copy link
Member Author

hugovk commented Apr 16, 2025

!buildbot ARM64 MacOS M1 Refleaks NoGIL

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 32104a3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132601%2Fmerge

The command will test the builders whose names match following regular expression: ARM64 MacOS M1 Refleaks NoGIL

The builders matched are:

  • ARM64 MacOS M1 Refleaks NoGIL PR

@hugovk
Copy link
Member Author

hugovk commented Apr 16, 2025

The builders matched are:

  • AMD64 CentOS9 NoGIL Refleaks PR

This one passed: https://buildbot.python.org/all/#/builders/1606/builds/299

The other is still pending.

@hugovk hugovk added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 32104a3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132601%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2025
@hugovk
Copy link
Member Author

hugovk commented Apr 16, 2025

The other is still pending.

Also passed: https://buildbot.python.org/#/builders/1367/builds/554

@nascheme
Copy link
Member

Please wait to see if GH-132611 fixes the problem before applying this revert.

@nascheme
Copy link
Member

Please wait to see if GH-132611 fixes the problem before applying this revert.

It seems that GH-132611 has fixed this problem. It was the "refleaks" option that was triggering the issue because it runs the same tests multiple times.

@hugovk
Copy link
Member Author

hugovk commented Apr 17, 2025

Great, thank you very much!

@hugovk hugovk closed this Apr 17, 2025
@hugovk hugovk deleted the 3.14-revert-d687900 branch April 17, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants