GH-123599: url2pathname(): don't call gethostbyname() by default
#132610
Conversation
…fault Follow-up to 0879ebc. Add *resolve_netloc* keyword-only argument to `url2pathname()`, defaulting to false. When set to true, we call `socket.gethostbyname()` to resolve the URL authority (netloc).
| @@ -1494,6 +1494,8 @@ def _is_local_authority(authority): | |||
| if authority == hostname: | |||
| return True | |||
| # Compare IP addresses | |||
| if not resolve: | |||
There was a problem hiding this comment.
I wonder, should we check this before calling gethostname() which can fail?
There was a problem hiding this comment.
I'm struggling to come up with firm info on when gethostname() fails (or whether it can perform network access). Do you have any pointers? Thanks.
There was a problem hiding this comment.
I do not know.
But I was thinking about this case: processing the "file:" URL on different computer. We cannot use gethostname(), because it returns a different result. If we want to get a path on other computer, we should ignore the host name. There will still be problem with processing Windows paths on Posix and Posix paths on Windows.
I do not know how common this case, and how common the opposite case, when we only use gethostname(), but not gethostbyname(). We should guess what would be more useful for users without having any data.
Misc/NEWS.d/next/Library/2024-11-14-21-17-48.gh-issue-126838.Yr5vKF.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
Thanks for the reviews - sorry for my slow response |
|
|
||
| .. versionchanged:: next | ||
| The *resolve_netloc* argument was added. | ||
| The *require_scheme* and *resolve_host* arguments were added. |
| discard authority if it resolves to a local IP address; otherwise | ||
| 4. On Windows, return a UNC path; otherwise | ||
| 5. (New) Raise :exc:`urllib.error.URLError`. | ||
| Add *resolve_host* keyword-only argument to |
| @@ -1494,6 +1494,8 @@ def _is_local_authority(authority): | |||
| if authority == hostname: | |||
| return True | |||
| # Compare IP addresses | |||
| if not resolve: | |||
| return False | |||
| try: | |||
| address = socket.gethostbyname(authority) | |||
| except (socket.gaierror, AttributeError): | |||
There was a problem hiding this comment.
| except (socket.gaierror, AttributeError): | |
| except (socket.gaierror, AttributeError, UnicodeEncodeError): |
gethostbyname tries to encode with IDNA, which can fail (e.g. on the unencodable characters we put into paths for our test suite)
Follow-up to 66cdb2b.
Add resolve_netloc keyword-only argument to
url2pathname(), defaulting to false. When set to true, we callsocket.gethostbyname()to resolve the URL authority (netloc).Path.from_uri()doesn't work if the URI contains host component #123599