Skip to content

gh-100239: specialize BINARY_OP/SUBSCR for list-slice #132626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 1, 2025

Conversation

@markshannon
Copy link
Member

markshannon commented Apr 17, 2025

list_subscript/_PyList_Subscript is the general subscript function for lists. I think we want to use a more specialized function that only works for slices. i.e this code: https://github.com/python/cpython/blob/main/Objects/listobject.c#L3614-L3618

@markshannon
Copy link
Member

The stats diff show a 50x increase in "subscr tuple slice" as a cause of specialization failure. Any idea why that might be? I can't see any reason for it.

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@iritkatriel iritkatriel enabled auto-merge (squash) May 1, 2025 10:15
@iritkatriel iritkatriel merged commit 5529213 into python:main May 1, 2025
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants